CHANGE: @W-19980062@: Switch to vitest and make tests more robust #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/ToViTest
branch
from
99b2215 to
d63051e
Compare
| // or just have one running logfile, we can change this. | ||
| const logFile = path.join(logFolder, `sfca-${formatToDateTimeString(clock.now())}.log`); | ||
| // 'w' flag causes the file to be created if it doesn't already exist. | ||
| const fh = await fs.open(logFile, 'w'); |
Contributor
Author
There was a problem hiding this comment.
Now we don't need this fs.open - thus also solving the file handle not closed issue.
jfeingold35
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.